-
-
Notifications
You must be signed in to change notification settings - Fork 5
Disable autocapitalize (almost) everywhere #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
e40c961 to
d9f9d01
Compare
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| className, | ||
| )} | ||
| bind:ref | ||
| autocapitalize="off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is it intentional to have spellcheck="false" in both input.svelte and textarea.svelte, but not here in command-input.svelte (which is used in multi-select and select)?
| bind:value={customExampleProjectName} | ||
| placeholder={$t`Project name...`} | ||
| onclick={(e) => e.stopPropagation()} | ||
| autocapitalize="on" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these things is not like the others. Was it intended here?
Autocapitalize=off is a reasonable default for our app.
Essentially all of our test fields are either data fields or fields for filtering by that data.
Arguably fields like Note or the Semantic domain filter should use autocapitalize, but instead of fine-tuning now, I want to just set the better global default.