Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Autocapitalize=off is a reasonable default for our app.

Essentially all of our test fields are either data fields or fields for filtering by that data.

Arguably fields like Note or the Semantic domain filter should use autocapitalize, but instead of fine-tuning now, I want to just set the better global default.

Copilot AI changed the title [WIP] Fix filter field capitalization in Fieldworks Lite Disable autocapitalization in filter and technical input fields Feb 6, 2026
Copilot AI requested a review from myieye February 6, 2026 09:45
Copilot AI changed the title Disable autocapitalization in filter and technical input fields Set autocapitalize="off" as default in base input components Feb 6, 2026
@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

UI unit Tests

  1 files  ±0   50 suites  ±0   24s ⏱️ ±0s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
203 runs  ±0  203 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d9f9d01. ± Comparison against base commit 0fc1ee6.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link

argos-ci bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Feb 6, 2026, 3:58 PM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

C# Unit Tests

146 tests  ±0   146 ✅ ±0   19s ⏱️ ±0s
 22 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d9f9d01. ± Comparison against base commit 0fc1ee6.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the copilot/fix-filter-field-uppercase branch from e40c961 to d9f9d01 Compare February 6, 2026 15:42
@myieye myieye changed the title Set autocapitalize="off" as default in base input components Disable autocapitalize (almost) everywhere Feb 6, 2026
@myieye myieye marked this pull request as ready for review February 6, 2026 15:46
@myieye
Copy link
Collaborator

myieye commented Feb 6, 2026

@coderabbitai full review

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Warning

Rate limit exceeded

@myieye has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch copilot/fix-filter-field-uppercase

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

className,
)}
bind:ref
autocapitalize="off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is it intentional to have spellcheck="false" in both input.svelte and textarea.svelte, but not here in command-input.svelte (which is used in multi-select and select)?

bind:value={customExampleProjectName}
placeholder={$t`Project name...`}
onclick={(e) => e.stopPropagation()}
autocapitalize="on"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these things is not like the others. Was it intended here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants