Added a "Give Feedback" dialog box

[tombogle]

This change is 

[andrew-polk]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @tombogle)

---

src/HearThis/HearThis.csproj line 14 at r1 (raw file):

    <AssemblyName>HearThis</AssemblyName>
    <TargetFramework>net472</TargetFramework>
	<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>

In case you care, this file seems to have a mix of indenting with tabs and spaces.

---

src/HearThis/UI/GiveFeedbackDlg.cs line 43 at r1 (raw file):

		public enum AffectedArea
		{
			NotApplicable, // Only available if Feedback type is Gratitude

or Donate, it appears

Maybe better to make it a more generic comment like
"Some TypeOfFeedback values do not allow this."

Code quote:

Gratitude

---

src/HearThis/UI/GiveFeedbackDlg.cs line 104 at r1 (raw file):

		}

		private void UpdateOkButtonState(object sender, EventArgs e)

Might as well remove this and the call

---

src/HearThis/UI/GiveFeedbackDlg.Designer.cs line 103 at r1 (raw file):

        " in the brackets is localizable. However, note that the URL it will take the use" +
        "r to is in English.");
			this.l10NSharpExtender1.SetLocalizingId(this._linkCommunityHelp, "ReportProblemDlg._linkCommunityHelp");

Is this supposed to be GiveFeedbackDlg?

Code quote:

ReportProblemDlg

---

src/HearThis/UI/Shell.cs line 35 at r1 (raw file):

using SIL.Windows.Forms.Extensions;
using static System.String;
using NewItemPlaceholderPosition = System.ComponentModel.NewItemPlaceholderPosition;

I'm guessing that adding this was a mistake?

---

src/HearThis/UI/Shell.cs line 963 at r1 (raw file):

						emailMessage.To.Add(ErrorReport.EmailAddress);
						emailMessage.Subject = dlg.Title;
						emailMessage.Body = "TODO: Complete this";

Is this a todo for you? Or for the user?
If the user, I think I would enhance this message. (And does it want to be localized?)

Later: Ok, I guess this is a work in progress... I see lots of todos.

Code quote:

TODO: Complete this

---

src/HearThis/UI/Shell.cs line 969 at r1 (raw file):

					catch (Exception)
					{
						//swallow it and go to the alternate method

what method? Could use an enhanced comment

Code quote:

the alternate method

---

src/HearThis/UI/Shell.Designer.cs line 277 at r1 (raw file):

			this.l10NSharpExtender1.SetLocalizationComment(this.giveFeedbackToolStripMenuItem, null);
			this.l10NSharpExtender1.SetLocalizationPriority(this.giveFeedbackToolStripMenuItem, L10NSharp.LocalizationPriority.NotLocalizable);
			this.l10NSharpExtender1.SetLocalizingId(this.giveFeedbackToolStripMenuItem, "Shell.Shell.giveFeedbackToolStripMenuItem");

Is that the l10n id you want?

Code quote:

Shell.Shell.giveFeedbackToolStripMenuItem

[tombogle]

Reviewable status: 3 of 7 files reviewed, 8 unresolved discussions (waiting on @andrew-polk and @tombogle)

---

src/HearThis/HearThis.csproj line 14 at r1 (raw file):

Previously, andrew-polk wrote…

In case you care, this file seems to have a mix of indenting with tabs and spaces.

I maybe care a little. I at least made them consistent in another branch.

---

src/HearThis/UI/GiveFeedbackDlg.cs line 43 at r1 (raw file):

Previously, andrew-polk wrote…

or Donate, it appears

Maybe better to make it a more generic comment like
"Some TypeOfFeedback values do not allow this."

Done.

---

src/HearThis/UI/GiveFeedbackDlg.Designer.cs line 103 at r1 (raw file):

Previously, andrew-polk wrote…

Is this supposed to be GiveFeedbackDlg?

Done.

---

src/HearThis/UI/Shell.cs line 35 at r1 (raw file):

Previously, andrew-polk wrote…

I'm guessing that adding this was a mistake?

Done.

---

src/HearThis/UI/Shell.Designer.cs line 277 at r1 (raw file):

Previously, andrew-polk wrote…

Is that the l10n id you want?

Fixed.

[andrew-polk]

Reviewed 3 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @andrew-polk and @tombogle)

---

src/HearThis/UI/GiveFeedbackDlg.Designer.cs line 385 at r3 (raw file):

			this.l10NSharpExtender1.SetLocalizableToolTip(this._lblWebsiteURL, null);
			this.l10NSharpExtender1.SetLocalizationComment(this._lblWebsiteURL, null);
			this.l10NSharpExtender1.SetLocalizationPriority(this._lblWebsiteURL, L10NSharp.LocalizationPriority.NotLocalizable);

Is this intentionally not localizable?

[andrew-polk]

Reviewed 3 of 3 files at r4, 2 of 7 files at r5, 2 of 2 files at r6, 3 of 6 files at r8, 2 of 5 files at r9, 4 of 4 files at r11, 3 of 4 files at r12, all commit messages.
Reviewable status: 11 of 13 files reviewed, 3 unresolved discussions (waiting on @tombogle)

[andrew-polk]

Reviewed 1 of 7 files at r5, 1 of 4 files at r12, 5 of 6 files at r14, 2 of 2 files at r15, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @tombogle)

---

src/HearThis/GiveFeedbackViewModel.cs line 71 at r15 (raw file):

		}

		public void IssueFeedback()

It doesn't seem like the best name, but I'm not sure exactly how it will used.

---

src/HearThis/GiveFeedbackViewModel.cs line 145 at r15 (raw file):

    public class Issuetype
    {
		[JsonPropertyName("id")]

Several lines indented with tabs.

---

DistFiles/ReleaseNotes.md line 43 at r15 (raw file):

## 3.5.1 (February 2024)
- Allowed HearThis desktop to attemp Android synchronization when using wired network connection.

I guess this is not new in this PR, but attemp is spelled wrong.

[andrew-polk]

Reviewed 1 of 1 files at r16, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @tombogle)

[tombogle]

DistFiles/ReleaseNotes.md line 43 at r15 (raw file):

Previously, andrew-polk wrote…

I guess this is not new in this PR, but attemp is spelled wrong.

Caught and fixed in a different PR

[andrew-polk]

Reviewed 8 of 8 files at r17, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @tombogle)