Make general LoggerMock#4138
Conversation
📝 WalkthroughWalkthroughThis PR refactors test dependencies in LiftControllerTests by extracting mocks into explicitly declared variables and introduces a new generic LoggerMock class to replace an inline MockLogger implementation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4138 +/- ##
===========================================
+ Coverage 74.76% 86.54% +11.78%
===========================================
Files 295 54 -241
Lines 10958 4758 -6200
Branches 1371 584 -787
===========================================
- Hits 8193 4118 -4075
+ Misses 2368 498 -1870
+ Partials 397 142 -255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).
Split off from #4122
This change is
Summary by CodeRabbit