Skip to content

Conversation

@SequeI
Copy link
Contributor

@SequeI SequeI commented Nov 24, 2025

Summary

Adding tests for the new custom sigstore instance addition, just to ensure everything stays working as intended, and is continously tested with each new codebase addition

Checklist
  • All commits are signed-off, using DCO
  • All new code has docstrings and type annotations
  • All new code is covered by tests. Aim for at least 90% coverage. CI is configured to highlight lines not covered by tests.
  • Public facing changes are paired with documentation changes
  • Release note has been added to CHANGELOG.md if needed

@SequeI SequeI requested review from a team as code owners November 24, 2025 13:44
@SequeI
Copy link
Contributor Author

SequeI commented Nov 24, 2025

Odd Hatch install failures, otherwise seems fine.

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look at the tests later, but wanted to submit the code changes first

@SequeI
Copy link
Contributor Author

SequeI commented Nov 27, 2025

Tests failing for a bunch of different reasons, not due to PR :)

EDIT: failures fixed in #575

@SequeI SequeI requested a review from mihaimaruseac November 27, 2025 12:24
Signed-off-by: SequeI <asiek@redhat.com>
Signed-off-by: SequeI <asiek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants