Skip to content

venus Task: Added per_page parameter to issues method#1303

Open
aakanksharajput14 wants to merge 2 commits intosigmavirus24:mainfrom
aakanksharajput14:main
Open

venus Task: Added per_page parameter to issues method#1303
aakanksharajput14 wants to merge 2 commits intosigmavirus24:mainfrom
aakanksharajput14:main

Conversation

@aakanksharajput14
Copy link

I have implemented the following changes to enhance the issues retrieval functionality:

Updated issues method: Added a new per_page parameter to the issues function to allow users to specify the number of results returned per page.

Modified repo_issue_params helper: Updated the helper function to accept the per_page argument and include it in the API request parameters.

Logic Integration: Added a conditional check within repo_issue_params to ensure per_page is only added to the params dictionary if it is explicitly provided.

These changes ensure better control over pagination when fetching repository issues via the GitHub API.

@sigmavirus24
Copy link
Owner

There are no tests to validate this and even GitHub Copilot seems to hallucinate features of the API. I'm not surprised if I missed that these endpoints support specifying the number of items per page, but we default to the max anyway when iterating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants