Python(refactor): update exports.proto to support parquet#510
Merged
Conversation
wei-qlu
force-pushed
the
python/update-export-proto-for-parquet
branch
from
da6ca37 to
7d869ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The backend exports.proto was updated to include parquet as one of the output formats. The sift client library export.proto was behind and needed to be updated.
I updated the exports.proto and included the format accordingly:
Verification
Unit tests for parquet as a output format.
Manual testing through several scenarios (e.g., exporting by runs, assets, time range, etc. as parquet).