Skip to content

python(chore): Fix integration tests relying on existing resources #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathan-sift wants to merge 1 commit into from
Closed

python(chore): Fix integration tests relying on existing resources #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions python/lib/sift_client/_tests/resources/test_reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,17 +146,16 @@ def test_archive(self, nostromo_run, test_rule, sift_client):
assert archived_report is not None
assert archived_report.is_archived == True

def test_unarchive(self, sift_client):
reports_from_rules = sift_client.reports.list_(
name="report_from_rules", include_archived=True
def test_unarchive(self, nostromo_run, test_rule, sift_client):
# create a report, archive it, then unarchive it
report_from_rules = sift_client.reports.create_from_rules(
name="report_from_rules_unarchive",
run=nostromo_run,
rules=[test_rule],
)
report_from_rules = None
for report_from_rules in reports_from_rules:
if report_from_rules.is_archived:
report_from_rules = report_from_rules
break
assert report_from_rules is not None
assert report_from_rules.is_archived == True
unarchived_report = sift_client.reports.unarchive(report=report_from_rules)
archived_report = sift_client.reports.archive(report=report_from_rules)
assert archived_report.is_archived is True
unarchived_report = sift_client.reports.unarchive(report=archived_report)
assert unarchived_report is not None
assert unarchived_report.is_archived == False
assert unarchived_report.is_archived is False
Loading