Skip to content

chore(element-ng): narrow @siemens/ngx-datatable peer dependency to v25#1498

Merged
spike-rabbit merged 1 commit intomainfrom
dep/ngx-datatable/enforce/latest
Feb 16, 2026
Merged

chore(element-ng): narrow @siemens/ngx-datatable peer dependency to v25#1498
spike-rabbit merged 1 commit intomainfrom
dep/ngx-datatable/enforce/latest

Conversation

@chintankavathia
Copy link
Copy Markdown
Member

BREAKING CHANGE: Dropped support for @siemens/ngx-datatable versions 22-24. Only version 25 is now supported as a peer dependency.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly narrows the peer dependency for @siemens/ngx-datatable to version 25 in projects/element-ng/package.json. The change is straightforward and aligns with the pull request's title. The inclusion of a BREAKING CHANGE notice in the description is appropriate for dropping support for older versions. The change looks good.

@github-actions
Copy link
Copy Markdown

@chintankavathia chintankavathia force-pushed the dep/ngx-datatable/enforce/latest branch from e486d1a to a4fc838 Compare February 16, 2026 10:15
@chintankavathia chintankavathia marked this pull request as ready for review February 16, 2026 11:06
@chintankavathia chintankavathia requested review from a team as code owners February 16, 2026 11:06
BREAKING CHANGE: Dropped support for @siemens/ngx-datatable versions 22-24. Only version 25 is now supported as a peer dependency.
@spike-rabbit spike-rabbit force-pushed the dep/ngx-datatable/enforce/latest branch from a4fc838 to 6a9cbc0 Compare February 16, 2026 15:25
@spike-rabbit spike-rabbit enabled auto-merge (rebase) February 16, 2026 15:25
@github-actions
Copy link
Copy Markdown

Code Coverage

@spike-rabbit spike-rabbit merged commit 14aea41 into main Feb 16, 2026
11 checks passed
@spike-rabbit spike-rabbit deleted the dep/ngx-datatable/enforce/latest branch February 16, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants