Conversation
There was a problem hiding this comment.
Code Review
The pull request adds a new update guide, which is a great addition. However, the structure of the guide could be confusing for users. The steps are not in a logical order, and it presents two different ng update commands, which could lead to errors. I've suggested a restructuring of the document to provide a clearer, step-by-step process for updating. The main points are to first update Angular, then Element, and to clarify what the automatic migration does versus what needs to be done manually.
|
Documentation. Coverage Reports: |
530dc9c to
1f4c7f5
Compare
1f4c7f5 to
773469d
Compare
spliffone
left a comment
There was a problem hiding this comment.
Can we state which @simpl/brand version is necessary, since the consumer can only guess which major version to use
1359ceb to
ba232e2
Compare
ba232e2 to
3c2c1b2
Compare
|
@spike-rabbit Should we mention about using new |
3c2c1b2 to
86bccaf
Compare
|
The |
timowolf
left a comment
There was a problem hiding this comment.
One little change request concerning the menu entry
17aad79 to
50599cf
Compare
|
LGTM, anything left to do here? |
50599cf to
47cf186
Compare
47cf186 to
56c542a
Compare
56c542a to
e5631fe
Compare
Adds a general update guide for element.