Skip to content

docs(updating): add update guide#1485

Merged
timowolf merged 1 commit intomainfrom
docs/add-updating-guide
Feb 18, 2026
Merged

docs(updating): add update guide#1485
timowolf merged 1 commit intomainfrom
docs/add-updating-guide

Conversation

@spike-rabbit
Copy link
Copy Markdown
Member

Adds a general update guide for element.


Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a new update guide, which is a great addition. However, the structure of the guide could be confusing for users. The steps are not in a logical order, and it presents two different ng update commands, which could lead to errors. I've suggested a restructuring of the document to provide a clearer, step-by-step process for updating. The main points are to first update Angular, then Element, and to clarify what the automatic migration does versus what needs to be done manually.

Comment thread docs/updating.md Outdated
@github-actions
Copy link
Copy Markdown

@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 530dc9c to 1f4c7f5 Compare February 10, 2026 09:48
Comment thread docs/updating.md Outdated
Comment thread docs/updating.md
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 1f4c7f5 to 773469d Compare February 10, 2026 11:05
Copy link
Copy Markdown
Member

@spliffone spliffone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we state which @simpl/brand version is necessary, since the consumer can only guess which major version to use

@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch 2 times, most recently from 1359ceb to ba232e2 Compare February 10, 2026 14:43
@spike-rabbit spike-rabbit added this to the 49.0.0 milestone Feb 16, 2026
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from ba232e2 to 3c2c1b2 Compare February 16, 2026 13:46
@spike-rabbit spike-rabbit marked this pull request as ready for review February 18, 2026 06:49
@spike-rabbit spike-rabbit requested review from a team as code owners February 18, 2026 06:49
Comment thread docs/updating.md Outdated
Comment thread docs/updating.md Outdated
@akashsonune
Copy link
Copy Markdown
Member

@spike-rabbit Should we mention about using new @siemens/element-icons package?

@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 3c2c1b2 to 86bccaf Compare February 18, 2026 13:02
@spike-rabbit
Copy link
Copy Markdown
Member Author

The @siemens/element-icons is covered by the schematics in general. I thought it was fine omitting them here

Copy link
Copy Markdown
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little change request concerning the menu entry

Comment thread docs/updating.md Outdated
Comment thread docs/updating.md Outdated
Comment thread docs/update-guides/update-v49.md
Comment thread mkdocs.yml Outdated
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch 2 times, most recently from 17aad79 to 50599cf Compare February 18, 2026 13:43
@akashsonune
Copy link
Copy Markdown
Member

LGTM, anything left to do here?

@timowolf timowolf force-pushed the docs/add-updating-guide branch from 50599cf to 47cf186 Compare February 18, 2026 15:16
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 47cf186 to 56c542a Compare February 18, 2026 15:23
@spike-rabbit spike-rabbit force-pushed the docs/add-updating-guide branch from 56c542a to e5631fe Compare February 18, 2026 15:33
@timowolf timowolf enabled auto-merge (rebase) February 18, 2026 15:35
@github-actions
Copy link
Copy Markdown

Code Coverage

@spike-rabbit spike-rabbit dismissed akashsonune’s stale review February 18, 2026 16:08

changes implemented

@timowolf timowolf merged commit c2d34cc into main Feb 18, 2026
24 of 28 checks passed
@timowolf timowolf deleted the docs/add-updating-guide branch February 18, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants