Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11627ccd7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def test_adbc_smoke_basic_execute(adbc_layer: SemanticLayer) -> None: | ||
| result = adbc_layer.adapter.execute("SELECT 1 as x, 2 as y") | ||
| assert result.fetchone() == (1, 2) |
There was a problem hiding this comment.
The CI matrix includes a Snowflake run but there’s no Snowflake service configured; _target_uri() hardcodes a dummy Snowflake URL, and the fixture only skips when ADBCAdapter initialization fails. Many ADBC drivers connect lazily, so execute("SELECT 1 as x, 2 as y") can be the first point of failure, which will raise and fail the test instead of skipping. This makes the “best‑effort” smoke job flaky or consistently failing whenever adbc_driver_snowflake installs successfully. Consider probing the connection in the fixture (and pytest.skip on failure) to keep the job best‑effort as intended.
Useful? React with 👍 / 👎.
1 participant
Adds ClickHouse ADBC dialect + URL support.
Runs ADBC unit coverage (URL parsing/dialect mapping) in default pytest runs.
Adds ADBC integration smoke matrix over postgres/bigquery/snowflake/clickhouse; installs drivers best-effort and skips when no working ADBC driver is available.