Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41fbabc7a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sidemantic/adapters/gooddata.py
Outdated
| if anchor_dim: | ||
| dimensions.append(anchor_dim) | ||
| primary_key = anchor_dim.name |
There was a problem hiding this comment.
In legacy GoodData LDMs, attribute identifiers (e.g., attr.orders.id) are semantic IDs, while the actual column comes from the label’s sourceColumn (e.g., order_id). Setting primary_key to anchor_dim.name means the SQL generator will emit attr.orders.id as a column (see sql/generator.py uses model.primary_key verbatim), which breaks joins and selects for legacy payloads where identifiers differ from physical columns. Consider using anchor_dim.sql (or the label source column) for primary_key so joins and SELECTs reference real columns.
Useful? React with 👍 / 👎.
1 participant
Adds GoodData LDM adapter for cloud and legacy payloads with metadata preservation and date instances. Adds metadata fields to core types plus Sidemantic adapter support, loader auto-detect, and README updates. Adds synthetic fixtures and tests for cloud/legacy/kitchen-sink cases.