Revert "Fixed .xpm cursor files to work with new glycin version"#810
Draft
Revert "Fixed .xpm cursor files to work with new glycin version"#810
Conversation
Member
|
What was the problem with #809 ? |
Member
Author
|
Looks like removing the const keyword leads to cursor icons being displayed as regular mouse pointer for all tools in the editor. At least this is what happens with latest git on my machine. |
Member
Author
|
Actually, I just tested with an older gdk-pixbuf2 version from before the whole mess started and latest git works as expected. Looks like the issue is somewhere in glycin or image-rs/image-extras. |
Member
Author
|
I guess, I figured out what the actual issue is and reported it upstream: https://gitlab.gnome.org/GNOME/glycin/-/work_items/291 We may or may not revert #809 because the const keyword issue will be fixed soon in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #809
PR #809 implements a workaround for loading cursor icon errors in recent glycin versions. With #809 the editor launches and is usable, but the cursor icons for various tools aren't displayed properly.
The proper fix is to revert #809 and wait for a fix in glycin. glycin uses image-rs/image-extras for loading XPM files. A fix in image-rs/image-extras has been released last week: image-rs/image-extras#47 Now we just need to wait for the next glycin version to pick it up, reported upstream: https://gitlab.gnome.org/GNOME/glycin/-/work_items/290
I propose to keep this as a draft as long as glycin is build with the broken image-rs/image-extras dependency, then merge it and thus revert #809 after the fixed glycin is released.