Open
Conversation
Currently in case trying to marshal a null URI struct, it tries to call `u.String()` function and panics. The marshal behavior should match the unmarshal behavior and return a `null` bytes array.
Author
|
cc @dmitshur |
YuviGold
added a commit
to YuviGold/test-infra
that referenced
this pull request
Oct 1, 2021
This was referenced Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in case trying to marshal a null
URIstruct, it tries to callu.String()function and panics.The marshal behavior should match the unmarshal behavior and return a
nullbytes array.Before changing the
scalar.gomodule, the new test scenario of anilURI would panicStacktrace (click to expand)