adding header for storage_upload and storage_download#8
adding header for storage_upload and storage_download#8shubhangi-google wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Accept-Encoding: gzip header to storage upload and download commands in base_service.rb and includes corresponding unit tests. The review feedback identifies a bug in the storage upload specification where an assignment operator was used instead of a comparison, and suggests improving the precision and robustness of header assertions in the service and download test suites.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds the Accept-Encoding: gzip header to storage upload and download commands in google-apis-core and includes corresponding test updates. The review feedback highlights that the current implementation for setting the header is case-sensitive, which could lead to duplicate headers if a user provides a lowercase key; a case-insensitive check is recommended. Furthermore, a consistency issue was noted in the test suite where one test case accesses the header directly on the command instead of through its options.
2 participants
No description provided.