SG-37555 Removed old build_resources.sh #108
Open
+66
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way UI resources are built and managed for the
launch_indicator_dialogcomponent. The main changes include removing the old shell script for building Qt UI files, updating the resource configuration to use a new build system, and regenerating thesplash_new.pyUI file using a more modern version of the Qt UI compiler.Build system improvements:
build_resources.shshell script, which previously handled building thesplash_newUI file using older tooling.build_resources.ymlto add a new entry for building thesplash_newUI file in thelaunch_indicator_dialogmodule, specifying the source and destination for the generated Python files.UI file updates:
splash_new.pyusing Qt User Interface Compiler version 5.15.2, resulting in modernized code style, updated import handling, and improved compatibility with newer Qt/PySide versions.splash_new.pyfor improved clarity and maintainability, including explicit object naming and use of updated Qt classes.