Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

Conversation

@sabsky
Copy link

@sabsky sabsky commented Mar 27, 2019

Adding RV markdown files (from AKN/CLC)

@sabsky sabsky requested a review from tannazie March 27, 2019 15:38
@manneohrstrom
Copy link
Contributor

Documentation Preview

1 similar comment
@manneohrstrom
Copy link
Contributor

Documentation Preview

Copy link
Contributor

@tannazie tannazie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I see that you added a bunch of files, but when I look at the preview, they're not showing up, because the TOC is still pointing to the external stuff.

I believe the file you need to change is this one: https://github.com/shotgunsoftware/developer.shotgunsoftware.com/blob/rv-markdown/docs/_data/toc.yml, though @manneohrstrom is the mastermind of that particular bit.

Remember also that you can preview, so you can see all your changes as they'll look on the site. After you commit, CI stuff runs (which can take a few minutes), then at the bottom of the feed on #56, there'll be a link like this:

RV_markdown_by_sabsky_·_Pull_Request__56_·_shotgunsoftware_developer_shotgunsoftware_com

Let me/Manne know if you get stuck on the TOC stuff. Thanks for doing this! So exciting!!

@sabsky
Copy link
Author

sabsky commented Mar 28, 2019

Thanks @tannazie ! I think I updated the toc file. I'm still not totally familiar with git, so let me know if there's something else I need to do so you can see the change!

@sabsky sabsky requested a review from tannazie March 28, 2019 04:03
@manneohrstrom
Copy link
Contributor

Documentation Preview

@manneohrstrom
Copy link
Contributor

Documentation Preview

@manneohrstrom
Copy link
Contributor

Documentation Preview

@sabsky
Copy link
Author

sabsky commented Apr 1, 2019

Awesome, thanks Tannaz! I think I've fixed the metadata problem. As for the content question, that's a larger question so I'm going to repost on our email thread and get some more input :) Thanks for all your help!

@manneohrstrom
Copy link
Contributor

Documentation Preview

@manneohrstrom
Copy link
Contributor

Documentation Preview

@sabsky
Copy link
Author

sabsky commented Apr 1, 2019

Darn, I think I need some help with the images as well. Right now my file path looks something like this: image

What should it be instead? (I made a separate rv folder to hold all the RV images).

@manneohrstrom
Copy link
Contributor

Documentation Preview

@manneohrstrom
Copy link
Contributor

Documentation Preview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants