This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Force Bundler version 1.17.2 to match Docker configuration
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfboismenu
approved these changes
Oct 18, 2021
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.6 | ||
| bundler: 1.17.2 |
Contributor
There was a problem hiding this comment.
Maybe add a comment above this saying that unpinning this breaks i18n image links? Until we know why, we should make sure nobody "cleans" this up.
jfboismenu
suggested changes
Oct 19, 2021
Contributor
jfboismenu
left a comment
jfboismenu
left a comment
There was a problem hiding this comment.
Given our discussion from this morning, we should update the PR description and the comments in the code since it doesn't fix i18n.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default bundler version provided by
ruby-setupdoesn't match the version specified for Docker or Travis. This appeared to lead to a regression in the i18n for images.