Skip to content

include analyze_snapshot in ios artifacts #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryanoltman merged 1 commit into from
Feb 7, 2025
Merged

include analyze_snapshot in ios artifacts #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sky/tools/create_ios_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ def main():
parser = argparse.ArgumentParser(
description=(
'Creates Flutter.framework, Flutter.xcframework and '
'copies architecture-dependent gen_snapshot binaries to output dir'
'copies architecture-dependent analyze_snapshot and gen_snapshot '
'binaries to output dir'
)
)

Expand Down Expand Up @@ -82,13 +83,17 @@ def main():
'%s_extension_safe' % simulator_x64_out_dir, '%s_extension_safe' % simulator_arm64_out_dir
)

# Copy gen_snapshot binary to destination directory.
# Copy analyze_snapshot and gen_snapshot binaries to destination directory.
if arm64_out_dir:
gen_snapshot = os.path.join(arm64_out_dir, 'gen_snapshot_arm64')
analyze_snapshot = os.path.join(arm64_out_dir, 'analyze_snapshot_arm64')
sky_utils.copy_binary(gen_snapshot, os.path.join(dst, 'gen_snapshot_arm64'))
sky_utils.copy_binary(analyze_snapshot, os.path.join(dst, 'analyze_snapshot_arm64'))
if x64_out_dir:
gen_snapshot = os.path.join(x64_out_dir, 'gen_snapshot_x64')
analyze_snapshot = os.path.join(x64_out_dir, 'analyze_snapshot_x64')
sky_utils.copy_binary(gen_snapshot, os.path.join(dst, 'gen_snapshot_x64'))
sky_utils.copy_binary(analyze_snapshot, os.path.join(dst, 'analyze_snapshot_x64'))

zip_archive(dst, args)
return 0
Expand Down Expand Up @@ -170,7 +175,7 @@ def zip_archive(dst, args):
# See: https://github.com/flutter/flutter/blob/62382c7b83a16b3f48dc06c19a47f6b8667005a5/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart#L82-L130

# Binaries that must be codesigned and require entitlements for particular APIs.
with_entitlements = ['gen_snapshot_arm64']
with_entitlements = ['analyze_snapshot_arm64', 'gen_snapshot_arm64']
with_entitlements_file = os.path.join(dst, 'entitlements.txt')
sky_utils.write_codesign_config(with_entitlements_file, with_entitlements)

Expand All @@ -196,6 +201,7 @@ def zip_archive(dst, args):
# pylint: enable=line-too-long

zip_contents = [
'analyze_snapshot_arm64',
'gen_snapshot_arm64',
'Flutter.xcframework',
'entitlements.txt',
Expand Down