Skip to content

fix(telemetry): send tracking events synchronously to prevent data loss on exit #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 7 commits into from
May 21, 2026
Merged

fix(telemetry): send tracking events synchronously to prevent data loss on exit #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
778dcc3
fix(telemetry): send tracking events synchronously to prevent data lo…
tturkowski May 18, 2026
dea56dd
fix(telemetry): add 2s timeout to tracking context to prevent blockin…
tturkowski May 19, 2026
186c0b1
fix(telemetry): add 2s timeout to tracking context to prevent blockin…
tturkowski May 19, 2026
be2b0dc
fix(telemetry): add 2s timeout to tracking to prevent blocking on net…
tturkowski May 19, 2026
ceaa396
fix(telemetry): add 2s timeout to tracking to prevent blocking on net…
tturkowski May 19, 2026
e8e5371
feat(telemetry): pass tracking context with timeout from callers
tturkowski May 20, 2026
c5721d5
Apply suggestions from code review
shyim May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/project/project_upgrade_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"path"
"strconv"
"strings"
"time"

"charm.land/huh/v2"
"charm.land/lipgloss/v2"
Expand Down Expand Up @@ -164,7 +165,9 @@ var projectUpgradeCheckCmd = &cobra.Command{
break
}
}
go tracking.Track(cmd.Context(), "project.upgrade_check", map[string]string{
trackCtx, trackCancel := context.WithTimeout(context.WithoutCancel(cmd.Context()), 300*time.Millisecond)
defer trackCancel()
tracking.Track(trackCtx, "project.upgrade_check", map[string]string{
"from_version": shopwareVersion.String(),
"target_version": selectedVersion,
"has_blockers": strconv.FormatBool(hasBlockers),
Expand Down
4 changes: 3 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ func Execute(ctx context.Context) {
name := strings.TrimPrefix(cmd.CommandPath(), "shopware-cli ")
name = strings.ReplaceAll(name, " ", ".")
name = strings.ReplaceAll(name, "-", "_")
go tracking.Track(ctx, "command", map[string]string{
trackCtx, trackCancel := context.WithTimeout(context.WithoutCancel(ctx), 300*time.Millisecond)
defer trackCancel()
tracking.Track(trackCtx, "command", map[string]string{
"command_name": name,
"result": result,
"duration_ms": strconv.FormatInt(time.Since(start).Milliseconds(), 10),
Expand Down