Skip to content

Conversation

@lanslide-team
Copy link
Contributor

This code should be merged with the latest dev branch.

@michihupf
Copy link
Contributor

What exactly does this add? Why would you ever need to manually lock teams?

@lanslide-team
Copy link
Contributor Author

The original PR was to introduce a "scrim mode" into the match setup.

The plugin itself assumes you have a list of players (probably from Get5) and generates the match config from this. The purpose of this PR was to allow a "scrim mode" where by, you can create a match based on the players connected to the server. The idea is the players are only "locked in" once the match goes live. This is useful for LAN tournaments and other situations where you don't know the player details ahead of time.

The small change here was to move the saving of playing team data from the post veto step to the "GoingLive" function (as this makes more sense).

@michihupf
Copy link
Contributor

The plugin does not assume a match to be set up, you do not need a list of players. Set .match mode to be the default mode in your config and when people join they can pick a team and ready up. Once all are ready the match will start. Depending on your config you can turn on knife round and playout to your liking. Maybe I am missing something but at that point all relevant data should be delivered correctly already.

@lanslide-team
Copy link
Contributor Author

Unless I'm mistaken, you can't do the veto map process without first loading a match config using the match setup mode.
I can't remember if there were other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants