Skip to content

Add optional Shipwright Triggers deployment support#290

Open
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
IrvingMg:feature/deploy-triggers-support
Open

Add optional Shipwright Triggers deployment support#290
IrvingMg wants to merge 1 commit intoshipwright-io:mainfrom
IrvingMg:feature/deploy-triggers-support

Conversation

@IrvingMg
Copy link
Copy Markdown
Member

Changes

Add optional Shipwright Triggers deployment support via spec.triggers.enable on the ShipwrightBuild CR.

  • Introduce a new TriggersSpec field and pkg/triggers package
  • Upgrade the TektonConfig profile from "lite" to "base" when enabled
  • Perform cleanup on disable or CR deletion
  • Add RBAC for triggers resources and Tekton API permissions

Related Issue

Fixes #240

Type of PR

/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add optional Shipwright Triggers support. Set `spec.triggers.enable: true` on the ShipwrightBuild CR to deploy the Triggers controller alongside Shipwright Build.

@openshift-ci openshift-ci bot added release-note kind/feature Categorizes issue or PR as related to a new feature. labels Mar 22, 2026
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 22, 2026
@IrvingMg
Copy link
Copy Markdown
Member Author

@shipwright-io/contributors PTAL

Copy link
Copy Markdown
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Marking "approve" to indicate this is a feature we want to include in the next release.

I have a few comments around the API and how we manage RBAC, plus an additional test scenario to consider. Otherwise this is a really solid PR - thanks @IrvingMg for the contribution!

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@adambkaplan adambkaplan added this to the release-v0.20.0 milestone Mar 30, 2026
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
@IrvingMg IrvingMg force-pushed the feature/deploy-triggers-support branch from 9f7a1e7 to ed238e7 Compare April 10, 2026 10:51
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[FEATURE] Deploy Triggers with Operator

3 participants