Increase Manila StorageClass sync wait delay#8
Open
imatza-rh wants to merge 1 commit into
Open
Conversation
The Manila CSI driver operator reconciles OpenStack share types to Kubernetes StorageClasses on a ~60-minute interval. The current delay of 15 seconds (60 retries x 15s = 15 min total) is not enough to catch the next resync after a new share type is created mid-cycle. Verified from operator logs: the csi-manila-default SC was created at 01:17:11 UTC and csi-manila-foo at 02:17:11 UTC - exactly 60 minutes apart. The test created the foo share type at 01:57:51 and gave up at 02:14:29, missing the sync by 2m 42s. Change delay from 15s to 60s (matching install_custom_mce and change_cloud_cm patterns), keeping 60 retries for a 60-minute total wait that covers the full CSI operator resync cycle. Change-Id: If18c7a148f4b8c708793154e4d77241797a7416c Signed-off-by: Itay Matza <imatza@redhat.com> Assisted-By: Claude Code Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
force-pushed
the
fix-manila-sc-retry-delay
branch
from
91a9963 to
be38bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Manila CSI driver operator reconciles OpenStack share types to Kubernetes StorageClasses on a ~60-minute interval. The current delay of 15 seconds (60 retries × 15s = 15 min total) is not enough to catch the next resync after a new share type is created mid-cycle.
Evidence
Verified from CSI driver operator logs:
csi-manila-defaultSC created (initial sync)csi-manila-fooSC created (next sync)Missed by 2 minutes 42 seconds. Same failure confirmed on multiple periodic runs.
Fix
Change
delayfrom 15s to 60s, matching existing patterns in the repo (install_custom_mce: 60 × 60s,change_cloud_cm: 30 × 120s). Same retry count, 60-minute total coverage.