Mysql tests #1024
Draft
Mysql tests #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an issue with non-deterministic fake data generated during test ( due to db race conditions ) simplifies testing dependencies: - replaces chai and mocha frameworks with node's own test-runner - replaces chai-http with supertest ( supertest is superagent's own http test helper; superagent is what chai-http used under the hood ) - removes lorem in favor of faker.lorem splits part of app.js into "appSetup.js" so that supertest can start the http listener server
it can't reliably handle line ending changes; and git reset --hard, and git stash are useless in these cases. these files aren't really needed. so just delete them. yay! source control. ~!*&@~!(&~((#&~(!&~!(@&(*!&(*
and remove excess afterCreate logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependencies on chai, chai-http, and mocha in favor of the node test runner.
Allows the unit tests to run against a standalone mysql container using:
npm run test -db=mysqlTo handle the mysql tests, the unit tests have to more correctly create and destroy tables during tests; so there are some changes for calls which setup and clean up the db tables
still marked as a draft because need to test the local site under docker to double check nothing broke ( ex. re the db startup calls )