Update node.js version to 22 #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates Node.js version from 18 to 22 across the build infrastructure and CI/CD workflows to use a more recent runtime version.
- Update Docker base images to use Node.js 22 compatible Alpine and Debian versions
- Update GitHub Actions workflows to use Node.js 22 instead of 18
- Add comprehensive compatibility testing for Node.js versions 16-22
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/linux/Dockerfile_linux_musl | Updates Alpine base image from 3.15 to 3.22 for Node.js 22 compatibility |
| pkg/linux/Dockerfile_linux_glibc | Updates Debian base image from buster to bullseye for Node.js 22 compatibility |
| .github/workflows/ci-pr-validation.yml | Updates CI workflows to use Node.js 22 and adds backward compatibility testing |
| .github/workflows/ci-build-release-napi.yml | Updates release workflow to use Node.js 22 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+176
to
178
| ./tests/load-test.sh node:22-bullseye ${{matrix.cpu.platform}} | ||
| ./tests/load-test.sh node:19-buster ${{matrix.cpu.platform}} | ||
| ./tests/load-test.sh node:19-bullseye ${{matrix.cpu.platform}} |
There was a problem hiding this comment.
[nitpick] The test order is inconsistent - Node.js 22 is tested first, then 19, then 18, then 16. Consider ordering tests from newest to oldest version consistently (22, 19, 18, 16) or oldest to newest for better readability.
Owner
Author
|
@copilot Please look at failed CI and push commit to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Master Issue: #
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)