Add an API to get and remove prefixes registered directly on an element#73
Open
danieldulaney wants to merge 5 commits intoshepmaster:masterfrom
Open
Add an API to get and remove prefixes registered directly on an element#73danieldulaney wants to merge 5 commits intoshepmaster:masterfrom
danieldulaney wants to merge 5 commits intoshepmaster:masterfrom
Conversation
added 5 commits
June 1, 2019 13:26
- New Element::registered_namespaces method - New failing tests
- Changed the API to return an impl Iterator (allows the consumer to iterate efficiently or convert to a Vec at their option) - Changed the tests from the previous commit to match the new API - Added an implementation in raw::Connections
Just a thin wrapper over std's HashMap::remove_entry
- Added a new raw::Storage::element_unregister_prefix private method
danieldulaney
changed the title
Contributor
Author
|
One question: Is there any way to remove strings from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of a resolution of #72. It adds an API to fetch the namespace registrations for a single element and an API to remove a namespace registration from a single element.
This API is different from other similar APIs because it returns an
impl Iteratorrather than aVec. I like this method because it lets the consumer decide whether or not the iterator needs to be collected, but it is a different approach. I'm very open to modifyingregistered_namespacesto return aVecinstead (which would be an easy change).Also, this required a
remove_entrymethod onLazyHashMap, a thin wrapper over the underlyingHashMap.Future work:
writermodule