fix(chunk): chunk detection when cursor on brace #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an off-by-one bug in `get_chunk_range_by_context` that caused incorrect chunk detection when cursor was on a brace. Specifically, the bug caused incorrect reading of the current character, resulting in `c` flag not being added to `searchpair` when necessary.
Author
|
Here's pictures to illustrate.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an off-by-one bug in
get_chunk_range_by_contextthat caused incorrect chunk detection when cursor was on a brace.Specifically, the bug caused incorrect reading of the current character, resulting in
cflag not being added tosearchpairwhen necessary.