fix: shpool builds on mac #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanpailes
reviewed
Jun 14, 2024
| if let Err(cause) = master.ptsname_r(&mut ptsname_buf) { | ||
| return Err(ForkError::BadMaster(cause)); | ||
| } | ||
| //if let Err(cause) = master.ptsname_r(&mut ptsname_buf) { |
Contributor
There was a problem hiding this comment.
if mac doesn't support ptsname_r, maybe we need to create the pty with openpty?
Also, just noticing this now, but this fork code is wrong. You aren't allowed to allocate in the child after a fork() call and this vec! constructor does so. We should probably fix that at some point.
Contributor
|
I think this is superceeded by #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just to demonstrate changes needed to get it to build