npm and node upgrade #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
worth to mention it fixes #10 |
shawnzhu
approved these changes
Dec 7, 2016
spec/dockerfile_spec.rb
Outdated
|
|
||
| describe command('npm -v') do | ||
| its(:stdout) { should match /2\.\d{1,2}\.\d{1,2}/ } | ||
| its(:stdout) { should match /3\.\10\.\9/ } |
Owner
There was a problem hiding this comment.
you don't need to change the minor and patch version number matching if you just want to verify if the npm is v3.x.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded npm to version 3.10.9 and node to version 6.9.2