Skip to content

Conversation

@atdrendel
Copy link
Contributor

@atdrendel atdrendel commented Apr 14, 2025

  • Add SQLiteDatabase.addCollation(named:comparator:) and SQLiteDatabase.removeCollation(named:)
  • Update GRDB to new major version 7

@atdrendel atdrendel requested a review from Copilot April 14, 2025 16:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Tests/SQLiteTests/SQLiteDatabaseTests.swift:235

  • [nitpick] Consider splitting the different collation scenarios into separate test cases to simplify debugging if one scenario fails.
for (toInsert, binarySort, localizedSort) in cases {

Sources/SQLite/SQLiteDatabase.swift:609

  • [nitpick] Consider adding a clarifying comment to explain that the comparator function in removeCollation is a dummy value since removal is based solely on the collation's name.
function: { _, _ in .orderedSame }

@atdrendel atdrendel merged commit 223e7d9 into main Apr 14, 2025
1 check passed
@atdrendel atdrendel deleted the collating-sequences branch April 14, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants