Skip to content

Conversation

@FabienLydoire
Copy link

The current code has not been updated in more than 3 years.
In this PR, I propose to :

  • Fix the build settings and syntax for Xcode 11
  • Fix the Unit Tests : for an unknown reason the file hash are different than the target ones from the unit tests
  • Build the SDK as 2 frameworks : 1 for device and 1 for simulator

@zmj
Copy link

zmj commented Dec 23, 2019

Hey Fabien, thanks so much for your work. I've asked internally whether we can accept your PR or refer visitors to your fork until this repo is updated. I probably won't have an update until January, but wanted to let you know that it's being discussed.

@FabienLydoire
Copy link
Author

Hey @zmj !
These are great news. Waiting for your feedback after end of year holidays then.

@zmj
Copy link

zmj commented Jan 13, 2020

Unfortunately, we're not able to accept PRs from outside of Citrix at this time. This repo's readme has been updated to refer visitors to your fork - thank you again for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants