fix(s01_agent_loop): fix Pylance type errors and subprocess output#107
Open
milocooper74575 wants to merge 1 commit intoshareAI-lab:mainfrom
Open
fix(s01_agent_loop): fix Pylance type errors and subprocess output#107milocooper74575 wants to merge 1 commit intoshareAI-lab:mainfrom
milocooper74575 wants to merge 1 commit intoshareAI-lab:mainfrom
Conversation
|
@milocooper74575 is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Problems:
Pylance error: Argument of type "list[dict[str, Unknown]]" cannot be assigned to parameter "tools" on line 71
Pylance error: Argument of type "object" cannot be assigned to parameter "command" on line 86
Changes Made:
Added ToolDef = Any type alias to properly annotate the tools list
Added explicit type annotation TOOLS: list[ToolDef]
Added type casting for block.input to fix the command type error
Simplified subprocess handling - changed from capture_output=True to stdout=subprocess.PIPE, stderr=subprocess.STDOUT which is more explicit