Skip to content

Sync address-review commands and add AGENTS.md/CLAUDE.md#54

Merged
justin808 merged 1 commit intomainfrom
jg/add-review-agent-command
Mar 22, 2026
Merged

Sync address-review commands and add AGENTS.md/CLAUDE.md#54
justin808 merged 1 commit intomainfrom
jg/add-review-agent-command

Conversation

@justin808
Copy link
Member

@justin808 justin808 commented Mar 22, 2026

Summary

Pulls over the latest address-review command improvements from the react_on_rails repository and establishes agent policy files (AGENTS.md, CLAUDE.md) for this Docusaurus site.

What changed

  • .claude/commands/address-review.md — Updated to the latest version from react_on_rails main. Key improvements:

    • $ARGUMENTS variable for Claude Code template input
    • --paginate on all REST API calls to handle multi-page responses
    • node_id / thread_id tracking via REST + GraphQL for reliable thread resolution
    • Review summary body fetch and reply path (uses issues endpoint, not /replies)
    • General PR discussion comments (issue comments) alongside inline review comments
    • Rationale reply UX — explicitly offers to post rationale replies for skipped/declined items
    • Sequential numbering across all triage categories
    • comments(first:100) inner pagination limitation documented
    • Reply context: replies with in_reply_to_id used as thread context instead of silently dropped
    • "non-actionable summaries" distinction in SKIPPED category
  • .agents/workflows/address-review.md — New shared prompt for Codex CLI, ChatGPT, Copilot, Cursor, and other non-Claude tools. Mirrors the Claude /address-review workflow with behavior rules for assistants that may lack terminal access.

  • AGENTS.md — New canonical agent policy adapted for this Docusaurus site. Includes Reusable Workflows section, project-specific commands, content flow, project structure, review workflow, and boundaries.

  • CLAUDE.md — New Claude-specific guidance that defers to AGENTS.md as the canonical source, with behavioral defaults and git safety rules.

Source PRs from react_on_rails

These changes incorporate work from the following merged PRs in shakacode/react_on_rails:

  • PR #2760 (merged 2026-03-19) — Synced address-review with triage improvements: $ARGUMENTS, review body fetch, node_id/thread_id tracking, --paginate + jq -s, GraphQL thread metadata query, known limitations section
  • PR #2761 (merged 2026-03-21) — Added .agents/workflows/address-review.md shared prompt for non-Claude tools, established the .agents/workflows/ convention, added "Reusable Workflows" section to AGENTS.md
  • PR #2798 (merged 2026-03-21) — Refined triage rules: replies used as thread context instead of dropped, "non-actionable summaries" distinction, all changes applied symmetrically to both Claude and shared prompt files

Earlier foundational PRs:

  • PR #2555 (merged 2026-03-08) — Bot comment deduplication, thread resolution via GraphQL, ID preservation through triage
  • PR #2656 (merged 2026-03-17) — Sequential numbering across triage categories
  • PR #2658 (merged 2026-03-18) — Rationale reply UX improvements
  • PR #2355 — Adopted AGENTS.md standard, separated agent policy from user guide
  • PR #2372 — Declared AGENTS.md as canonical, refactored CLAUDE.md to defer to it
  • PR #2557 (merged 2026-03-08) — Added Review Workflow section to AGENTS.md

Design decisions

  • Two parallel files: .claude/commands/address-review.md for Claude Code slash commands, .agents/workflows/address-review.md for all other tools — following the convention established in react_on_rails PR #2761
  • AGENTS.md is canonical: All agent tools read AGENTS.md; CLAUDE.md adds only Claude-specific behavioral notes — following the pattern from react_on_rails PR #2372
  • AGENTS.md adapted for Docusaurus: Commands, project structure, and boundaries are specific to this npm/Docusaurus/Cloudflare Pages project, not copied verbatim from the Ruby gem repo

Test plan

  • Verify /address-review slash command works in Claude Code against a PR in this repo
  • Verify .agents/workflows/address-review.md prompt works when pasted into Codex CLI
  • Confirm AGENTS.md and CLAUDE.md are picked up by Claude Code and other agent tools

🤖 Generated with Claude Code


Note

Low Risk
Documentation/workflow-only changes affecting AI agent prompts and repo guidance; no runtime code or build logic is modified.

Overview
Updates the Claude /address-review command to a more robust workflow: supports PR/review/comment URLs, paginates GitHub API fetches, includes review summary bodies and general PR comments, maps node_id to GraphQL thread_id for resolving threads, and refines triage/UX (reply handling, sequential numbering, optional rationale replies).

Adds a non-Claude equivalent prompt in .agents/workflows/address-review.md, and introduces AGENTS.md (canonical agent policy for this Docusaurus repo) plus CLAUDE.md (Claude-specific guidance that defers to AGENTS.md).

Written by Cursor Bugbot for commit c448e16. This will update automatically on new commits. Configure here.

Pull latest address-review command improvements from react_on_rails
and establish agent policy files for this Docusaurus site.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 756ba377-98ab-474c-9598-b25b16ff9efb

📥 Commits

Reviewing files that changed from the base of the PR and between 7701418 and c448e16.

📒 Files selected for processing (4)
  • .agents/workflows/address-review.md
  • .claude/commands/address-review.md
  • AGENTS.md
  • CLAUDE.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg/add-review-agent-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Cloudflare preview deployed.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c448e166be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +50 to +54
# Review body (often contains summary feedback)
gh api repos/${REPO}/pulls/{PR_NUMBER}/reviews/{REVIEW_ID} | jq '{id: .id, body: .body, state: .state, user: .user.login, html_url: .html_url}'

# Inline comments for this review
gh api --paginate repos/${REPO}/pulls/{PR_NUMBER}/reviews/{REVIEW_ID}/comments | jq -s '[.[].[] | {id: .id, node_id: .node_id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Tag specific review bodies as review summaries

When /address-review is invoked with a #pullrequestreview-... URL and the actionable feedback lives in the review body rather than an inline comment, Step 3 stores that payload as only {id, body, state, user, html_url}. Unlike the full-PR path later in this file, there is no type: "review_summary" marker, so the later reply logic in Step 7 cannot distinguish a review summary from a normal review comment and can route the response through /comments/{COMMENT_ID}/replies using the review ID. That endpoint only accepts review-comment IDs, so this case cannot be replied to correctly.

Useful? React with 👍 / 👎.


## Behavioral Defaults

- When confident in your changes, **commit and push without asking for permission**. Always monitor CI after pushing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the auto-push default that bypasses ask-first rules

This new default tells Claude Code to commit and push immediately whenever it is confident, but the canonical policy added in AGENTS.md requires asking first for .github/workflows/, scripts/, and Docusaurus config changes and waiting for the first full review pass before follow-up pushes. On tasks that touch those areas, Claude will now be instructed to violate the repo's own safety boundaries instead of pausing for approval.

Useful? React with 👍 / 👎.

@justin808 justin808 merged commit 03a8fb2 into main Mar 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant