Skip to content

Tests: validate useradd behavior for invalid, out-of-range, and maximum boundary UIDs#1604

Merged
ikerexxe merged 2 commits intoshadow-maint:masterfrom
aborah-sudo:user_add1
Mar 31, 2026
Merged

Tests: validate useradd behavior for invalid, out-of-range, and maximum boundary UIDs#1604
ikerexxe merged 2 commits intoshadow-maint:masterfrom
aborah-sudo:user_add1

Conversation

@aborah-sudo
Copy link
Copy Markdown
Contributor

This is the transformation to Python of the test located in tests/usertools/01/13_useradd_negative_UID.test, tests/usertools/01/14_useradd_out_of_range_UID.test which checks that useradd can not add a new user with invalid UID

Copy link
Copy Markdown
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the current PR touches several distinct test files I suggest updating the title to something like ''Tests: validate useradd behavior for invalid, out-of-range, and maximum boundary UIDs'.

Additionally, can you wrap the commit message lines at roughly 72 characters? Some of the lines are quite long, and keeping them within standard widths ensures the git history remains readable for everyone using terminal-based tools.

@aborah-sudo aborah-sudo changed the title Tests: Add a new user with an invalid UID Tests: validate useradd behavior for invalid, out-of-range, and maximum boundary UIDs Mar 31, 2026
@aborah-sudo aborah-sudo force-pushed the user_add1 branch 3 times, most recently from 366a61a to 15fe4b8 Compare March 31, 2026 08:27
This is the transformation to Python of the test located in
`tests/usertools/01/13_useradd_negative_UID.test`,
`tests/usertools/01/14_useradd_out_of_range_UID.test`
which checks that `useradd` can not add a new user with invalid UID
@aborah-sudo aborah-sudo force-pushed the user_add1 branch 2 times, most recently from a155c63 to 093995a Compare March 31, 2026 08:49
@aborah-sudo aborah-sudo requested a review from ikerexxe March 31, 2026 08:50
This is the transformation to Python of the test located in
`tests/usertools/01/15_useradd_specified_large_UID.test` which
checks that `useradd` can add a new user with large UID
Copy link
Copy Markdown
Collaborator

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikerexxe ikerexxe merged commit 6af798f into shadow-maint:master Mar 31, 2026
16 checks passed
@aborah-sudo aborah-sudo deleted the user_add1 branch April 1, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants