Bind BedEncoder lifetime to the plink-server connection#11
Merged
jeromekelleher merged 1 commit intosgkit-dev:mainfrom May 7, 2026
Merged
Bind BedEncoder lifetime to the plink-server connection#11jeromekelleher merged 1 commit intosgkit-dev:mainfrom
jeromekelleher merged 1 commit intosgkit-dev:mainfrom
Conversation
Replace the lazy-allocate-on-first-READ + manual try/finally cleanup in `_handle_connection` with an upfront BedEncoder construction wrapped in a `with` block. If construction fails the server now writes an errno reply on the socket (via `pack_error_reply`) before returning, so the parent FUSE layer surfaces a real `OSError` rather than an unexplained EOF. Adds tests covering both the matching-errno and EIO-fallback paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the lazy-allocate-on-first-READ + manual try/finally cleanup in
_handle_connectionwith an upfront BedEncoder construction wrapped in awithblock. If construction fails the server now writes an errno reply on the socket (viapack_error_reply) before returning, so the parent FUSE layer surfaces a realOSErrorrather than an unexplained EOF. Adds tests covering both the matching-errno and EIO-fallback paths.