Skip to content

Conversation

@sgerrand
Copy link
Owner

@sgerrand sgerrand commented Sep 13, 2024

💁 Time moves on and the ages in these examples are no longer valid. These changes replace static ages with their calculated equivalents so that they can be rerun at any time with confidence.

(This is a migration of duffelhq#97, the repository for which was archived upstream.)

⚠️ The test suite wouldn't run so to get that passing I've also made the following changes:

  • updated gc_ruboconfig, rubocop gems
  • fixed various offences raised by RuboCop
  • fixed a silently broken test case
  • bumped the minimum Ruby version to 2.7 (this version is EOL)
  • updated the version of the artifacts GitHub Action to 4 to address the deprecation error

Time moves on and the ages in these examples are no longer valid. These
changes replace static ages with calculated equivalents so that they can
be rerun at any time with confidence.
@sgerrand sgerrand added the bug Something isn't working label Sep 13, 2024
sgerrand and others added 8 commits September 13, 2024 15:27
Gemspec/DevelopmentDependencies: Specify development dependencies in
Gemfile.
Pull test case out of setup.
- Remove Ruby 2.6: rubocop >= 1.51.0 depends on Ruby >= 2.7.0
- Add modern, generally available Ruby versions: 3.2, 3.3
Style/SuperArguments: Call super without arguments and parentheses when
the signature is identical.
Style/RedundantInterpolation: Prefer to_s over string interpolation.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v2...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Owner Author

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sgerrand sgerrand merged commit 6992d61 into main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants