Skip to content

merge in SFC client code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianlechthaler merged 15 commits into from
Nov 8, 2025
Merged

merge in SFC client code #1

brianlechthaler merged 15 commits into from
Nov 8, 2025

Conversation

@brianlechthaler
Copy link
Collaborator

@brianlechthaler brianlechthaler commented Nov 8, 2025

adds client functionality including creating/destroying/listing instances

@brianlechthaler
add scaffolding, and client authentication.
fb29dda
@brianlechthaler
return APITypeGlobal from GetAPIType function, as SFC accounts are no…
15549b7 
…t tied to specific regions.
@brianlechthaler
fix apiKey in SFCCredential struct
ce73d06
@brianlechthaler
scaffolding for instance.go
0081586
@brianlechthaler
add instance creation implementation with SSH key support
138d63d
@brianlechthaler
add function to map the status of a node reported from SFC API to v1.…
30dbe43 
…LifecycleStatus in Brev
@brianlechthaler
implement GetInstance in sfcompute with node data retrieval inluding …
7788710 
…SSH Hostname / Public IP
@brianlechthaler
add TerminateInstance implementation with node release and delete logic
60ef719
@brianlechthaler
set default SSH port to 2222, as is standard for our platform
692ccf8
@brianlechthaler
implement GetSSHHostname for retrieving the SSH hostname of an instan…
67f3ca4 
…ce in sfcompute
@brianlechthaler
remove unneeded call to api for GetSSHHostname
be27295
@brianlechthaler
use VM ID instead of instance ID to retrieve SSH Hostname
a556e6b
@brianlechthaler
remove get ssh hostname function
d6f3729
@brianlechthaler
implement ListInstances
42771b9
@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  go.mod Unsupported file format
  go.sum Unsupported file format
  v1/providers/sfcompute/capabilities.go  0% smaller
  v1/providers/sfcompute/client.go  0% smaller
  v1/providers/sfcompute/instance.go  0% smaller

@brianlechthaler brianlechthaler merged commit a3b7a5d into main Nov 8, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brianlechthaler