fix: align container and extension definitions to the spec #8
+87
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Graf <arminhammer@gmail.com>
Signed-off-by: Armin Graf <arminhammer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
This PR does two things:
I added a unit test that copies https://github.com/serverlessworkflow/specification/blob/main/examples/mock-service-extension.yaml verbatim and tries to create a
WorkflowDefinitionfrom it. This test fails without the fix, and succeeds with the fix.stdinandargumentsfrom the ContainerProcessDefinition, despite being defined in the spec. This PR adds those properties to the type.Special notes for reviewers:
Additional information (if needed):