Skip to content

[Fix #1351] Generating native file#1370

Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:Fix_#1351
May 5, 2026
Merged

[Fix #1351] Generating native file#1370
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:Fix_#1351

Conversation

@fjtirado
Copy link
Copy Markdown
Collaborator

@fjtirado fjtirado commented May 5, 2026

Fix #1351

@fjtirado fjtirado force-pushed the Fix_#1351 branch 4 times, most recently from 7c5b080 to d47c883 Compare May 5, 2026 15:02
@fjtirado fjtirado marked this pull request as ready for review May 5, 2026 15:13
Copilot AI review requested due to automatic review settings May 5, 2026 15:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds GraalVM native-image reflection metadata support by introducing reflect-config.json resources for key modules and extending the Jackson generator to emit reflection config alongside generated mix-in sources.

Changes:

  • Added GraalVM reflect-config.json resources for impl-openapi and impl-core.
  • Extended the Jackson generator to generate META-INF/native-image/<groupId>/<artifactId>/reflect-config.json into build output resources.
  • Adjusted generated serializer/deserializer visibility to public and updated api build resources to include generated resources.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
impl/openapi-jackson/src/main/resources/META-INF/native-image/io.serverlessworkflow/serverlessworkflow-impl-openapi/reflect-config.json Adds reflection config entries for UnifiedOpenAPI and nested types.
impl/core/src/main/resources/native-image/io.serverlessworkflow/serverlessworkflow-impl-core/reflect-config.json Adds reflection config entry for WorkflowError.
generators/jackson/src/main/java/io/serverlessworkflow/generator/jackson/JacksonMixInPojo.java Generates reflection config during mix-in generation and registers some generated classes.
generators/jackson/src/main/java/io/serverlessworkflow/generator/jackson/GeneratorUtils.java Makes generated serializer/deserializer classes public.
api/pom.xml Includes generated resources directory in build resources so generated reflect-config is packaged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/pom.xml
@fjtirado fjtirado marked this pull request as draft May 5, 2026 15:29
@fjtirado fjtirado force-pushed the Fix_#1351 branch 4 times, most recently from 762322b to d7ae3ca Compare May 5, 2026 16:27
@fjtirado fjtirado marked this pull request as ready for review May 5, 2026 16:28
Copilot AI review requested due to automatic review settings May 5, 2026 16:28
Copy link
Copy Markdown
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: fjtirado <ftirados@redhat.com>
Copilot AI review requested due to automatic review settings May 5, 2026 17:15
@fjtirado fjtirado merged commit 595579f into serverlessworkflow:main May 5, 2026
6 of 7 checks passed
@fjtirado fjtirado review requested due to automatic review settings May 5, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add native image support

3 participants