fix(stateMachine): guard pseudo-parameter validation + fix apiKeys docs#725
Open
fix(stateMachine): guard pseudo-parameter validation + fix apiKeys docs#725
Conversation
- Add regression test confirming #{AWS::Region} style pseudo-parameters
do not fail ASL validation (fixed in asl-validator v3.11.0, no test
existed to guard against a future regression) — closes #291
- Fix README apiKeys example: nest usagePlan under apiGateway and move
stepFunctions to top-level (was incorrectly nested under functions) — closes #566
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two unrelated quick fixes bundled into one PR:
Regression test for pseudo-parameter validation (Validate fails when state resource uses pseudo parameters from the serverless-pseudo-parameters plugin #291) — adds a test confirming that
#{AWS::Region}style pseudo-parameters in state machine resource ARNs do not fail ASL validation whenvalidate: trueis set. The underlying issue was fixed byasl-validatorv3.11.0 relaxing its ARN regex, but no test existed to guard against a future regression.README apiKeys example fix (apiKeys property is not nested under apiGateway property in API Gateway documentation section #566) — the
usagePlanblock was incorrectly placed at theproviderlevel instead of nested underapiGateway, andstepFunctionswas incorrectly nested underfunctions.helloinstead of being a top-level key.Why
Closes #291
Closes #566
Test plan
should not fail validation when definition contains pseudo-parameters— passes with currentasl-validatorv3.11.0npm test— 498 passing🤖 Generated with Claude Code