Skip to content

My new awesome feature#1

Open
sergiou87 wants to merge 3 commits intodevelopmentfrom
my-awesome-feature
Open

My new awesome feature#1
sergiou87 wants to merge 3 commits intodevelopmentfrom
my-awesome-feature

Conversation

@sergiou87
Copy link
Owner

@sergiou87 sergiou87 commented Mar 29, 2022

This awesome feature is made of awesome changes.

@sergiou87 sergiou87 changed the title Make some awesome changes My new awesome feature Mar 29, 2022
serpa1
serpa1 suggested changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 😍

Take a look at my suggestions and let me know what you think. I also found this text has the wrong font size:

2022-03-29 at 18 15

serpa1
serpa1 suggested changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 😍

Take a look at my suggestions and let me know what you think. I also found this text has the wrong font size:

2022-03-29 at 18 15

serpa1
serpa1 suggested changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 😍

Take a look at my suggestions and let me know what you think. I also found this text has the wrong font size:

2022-03-29 at 18 15

serpa1
serpa1 suggested changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat

serpa1
serpa1 approved these changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes! Looks great now :shipit:

serpa1
serpa1 suggested changes Mar 29, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz work

serpa1
serpa1 suggested changes Mar 30, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something ❤️

serpa1
serpa1 suggested changes Mar 30, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello world

serpa1
serpa1 suggested changes Mar 30, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good ❤️

serpa1
serpa1 suggested changes Mar 31, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 😍

Take a look at my suggestions and let me know what you think. I also found this text has the wrong font size:

2022-03-29 at 18 15

serpa1
serpa1 approved these changes Mar 31, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes! Looks great now :shipit:

serpa1
serpa1 suggested changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do something!!

serpa1
serpa1 approved these changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 3.0

serpa1
serpa1 suggested changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some changes 3.0

serpa1
serpa1 suggested changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something something 3.0?

serpa1
serpa1 approved these changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications disabled 3.0¿

serpa1
serpa1 reviewed Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications disabled 3.0?

serpa1
serpa1 approved these changes Apr 26, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello notifications

@serpa1
Copy link

serpa1 commented May 4, 2022

asdfasdf

serpa1
serpa1 reviewed May 4, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fasdfasdf

serpa1
serpa1 reviewed May 4, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello world

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best code

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asdf

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another test

serpa1
serpa1 approved these changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

serpa1
serpa1 suggested changes May 5, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred test

serpa1
serpa1 reviewed May 11, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
run: exit 0 # echo "::set-output name=dir::$(yarn cache dir)"
Copy link

@serpa1 serpa1 May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment

Copy link

@serpa1 serpa1 May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdf

Copy link

@serpa1 serpa1 May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there

Copy link

@serpa1 serpa1 May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever

serpa1
serpa1 reviewed May 18, 2022
View reviewed changes
.github/workflows/ci.yml
run: exit 0 # yarn test:script:cov
- name: Publish production app
run: yarn run publish
run: exit 0 # yarn run publish
Copy link

@serpa1 serpa1 May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single comment

serpa1
serpa1 approved these changes May 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, I like it

serpa1
serpa1 suggested changes May 20, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change things plz

serpa1
serpa1 approved these changes May 23, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR

serpa1
serpa1 approved these changes May 23, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR

serpa1
serpa1 suggested changes May 23, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me changes

serpa1
serpa1 reviewed May 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment

serpa1
serpa1 approved these changes May 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdf

serpa1
serpa1 approved these changes Jun 6, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

serpa1
serpa1 suggested changes Jun 13, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdasdfasd

serpa1
serpa1 approved these changes Jun 13, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fddfasa

serpa1
serpa1 suggested changes Jun 13, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdf

serpa1
serpa1 approved these changes Jun 13, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdf

serpa1
serpa1 approved these changes Jun 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adsfadsf

serpa1
serpa1 suggested changes Jun 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope nope nope

serpa1
serpa1 suggested changes Jun 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

serpa1
serpa1 approved these changes Jun 24, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfadsf

serpa1
serpa1 suggested changes Oct 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adsfasdf

serpa1
serpa1 approved these changes Oct 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdf

serpa1
serpa1 suggested changes Oct 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdffdd

serpa1
serpa1 approved these changes Oct 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdfasdfasdf

serpa1
serpa1 approved these changes Oct 19, 2022
View reviewed changes
Copy link

@serpa1 serpa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@serpa1 serpa1 serpa1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergiou87 @serpa1