✨ Keycloak: Configuration to support multiple certificates in Election Event - Follow Up#2597
Open
BelSequent wants to merge 8 commits intomainfrom
Open
✨ Keycloak: Configuration to support multiple certificates in Election Event - Follow Up#2597BelSequent wants to merge 8 commits intomainfrom
BelSequent wants to merge 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up changes to the certificate authority import/parsing flow to better support multi-certificate bundles by adding validation around certificate expiration and strengthening date parsing tests.
Changes:
- Add unit tests validating
notAfterdates parse to timestamps in the past/future. - Skip importing certificates that are already expired (based on
not_aftervs current time) and report them back to the caller.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/windmill/src/services/certificate_authority.rs |
Extends test coverage for OpenSSL date parsing with explicit past/future notAfter assertions. |
packages/harvest/src/routes/import_certificate_authority.rs |
Adds an expiration check during CA bundle import to skip expired certs and record an error message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/11926