Skip to content

✨ Keycloak: Configuration to support multiple certificates in Election Event - Follow Up#2597

Open
BelSequent wants to merge 8 commits intomainfrom
feat/meta-11926/main
Open

✨ Keycloak: Configuration to support multiple certificates in Election Event - Follow Up#2597
BelSequent wants to merge 8 commits intomainfrom
feat/meta-11926/main

Conversation

@BelSequent
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings April 23, 2026 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up changes to the certificate authority import/parsing flow to better support multi-certificate bundles by adding validation around certificate expiration and strengthening date parsing tests.

Changes:

  • Add unit tests validating notAfter dates parse to timestamps in the past/future.
  • Skip importing certificates that are already expired (based on not_after vs current time) and report them back to the caller.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/windmill/src/services/certificate_authority.rs Extends test coverage for OpenSSL date parsing with explicit past/future notAfter assertions.
packages/harvest/src/routes/import_certificate_authority.rs Adds an expiration check during CA bundle import to skip expired certs and record an error message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/harvest/src/routes/import_certificate_authority.rs Outdated
Comment thread packages/harvest/src/routes/import_certificate_authority.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants