fix(rules): Remove false positives from path-traversal temp-file/temp-directory sinks#69
Open
misonijnik wants to merge 2 commits intomainfrom
Open
fix(rules): Remove false positives from path-traversal temp-file/temp-directory sinks#69misonijnik wants to merge 2 commits intomainfrom
misonijnik wants to merge 2 commits intomainfrom
Conversation
…-directory sinks The createTempFile and createTempDirectory sink patterns previously matched user-controlled prefix/suffix String arguments, which cannot cause path traversal because the JDK rejects platform file separators in those positions. - File.createTempFile: narrow to 3-arg form so only the directory arg is a sink - Files.createTempFile: type-constrain to Path overload (directory), skip String overload (prefix/suffix) - Files.createTempDirectory: same type-constraint for Path overload - Fix typo: readSymbolicPath → readSymbolicLink - Add negative tests for all fixed cases in both Servlet and Spring samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The createTempFile and createTempDirectory sink patterns previously matched user-controlled prefix/suffix String arguments, which cannot cause path traversal because the JDK rejects platform file separators in those positions.