test(core): Add nested-array element taint repro#151
Draft
misonijnik wants to merge 2 commits into
Draft
Conversation
Adds a minimal IFDS taint reproducer: when an element of a tainted array is itself an array that is later indexed (Object[] holding a String[]), the taint is dropped. The source's element path is transferred to a reference fact on the destination (types.$) instead of a nested element fact (types[*]), so the inner element read is not considered tainted. issue98 carries two positive samples: - PositiveScalarElementControl — scalar element of tainted array -> sink (passes today) - PositiveNestedArrayElement — (String[]) args[1] then types[0] -> sink (missed) This is the shape of Apache Dubbo GenericFilter's provider path (String[] parameterTypes = (String[]) invocation.getArguments()[1] -> ReflectUtils.name2class(parameterTypes[i])). The test is @disabled pending an engine fix, matching the convention used for the other known-miss issues.
… loudly Remove @disabled from the issue 98 reproducer. The test now fails (the PositiveNestedArrayElement sample is missed) instead of being skipped, so the engine regression is visible until the nested-array element taint propagation is fixed.
Contributor
|
Wiil be fixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.