Skip to content

Measurement fix by @endryha (issue #1) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
almozavr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Measurement fix by @endryha (issue #1) #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 34 additions & 15 deletions ...lVariableListView/src/it/sephiroth/android/library/widget/HorizontalVariableListView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,21 +488,40 @@ public void setSelection( int position ) {}
*
* @see android.view.View#onMeasure(int, int)
*/
@Override
protected void onMeasure( int widthMeasureSpec, int heightMeasureSpec ) {

int parentWidth = MeasureSpec.getSize(widthMeasureSpec);
int parentHeight = MeasureSpec.getSize(heightMeasureSpec);

if( mChildHeight != 0 ) {
setMeasuredDimension( parentWidth, mChildHeight );
} else {
setMeasuredDimension( parentWidth, 0 );
}

mHeightMeasureSpec = heightMeasureSpec;
mWidthMeasureSpec = widthMeasureSpec;
}
@Override
protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
int parentWidth = MeasureSpec.getSize(widthMeasureSpec);
int parentHeight = MeasureSpec.getSize(heightMeasureSpec);
if (mChildHeight == 0) {
if (mAdapter != null && mAdapter.getCount() > 0) {
int viewType = mAdapter.getItemViewType(0);
View child = mAdapter.getView(0, mRecycleBin.get(viewType).poll(), this);

LayoutParams params = child.getLayoutParams();

if (params == null) {
params = new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);
}

int childHeightSpec = ViewGroup.getChildMeasureSpec(mHeightMeasureSpec, getPaddingTop() + getPaddingBottom(), params.height);
int childWidthSpec = ViewGroup.getChildMeasureSpec(mWidthMeasureSpec, getPaddingLeft() + getPaddingRight(), params.width);
child.measure(childWidthSpec, childHeightSpec);

mChildHeight = child.getMeasuredHeight();

setMeasuredDimension(parentWidth, mChildHeight);
}
else {
setMeasuredDimension(parentWidth, parentHeight);
}
}
else {
setMeasuredDimension(parentWidth, mChildHeight);
}

mHeightMeasureSpec = heightMeasureSpec;
mWidthMeasureSpec = widthMeasureSpec;
}

/**
* Adds the and measure child.
Expand Down