Fix HTTPClient requesting non-existent /details endpoint#219
Open
sentry[bot] wants to merge 1 commit into
Open
Fix HTTPClient requesting non-existent /details endpoint#219sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Change HTTPClient.makeRequest() to use /products instead of /details. The /details endpoint does not exist on the Flask backend, causing a 404 error every time the error_404 button is tapped in MainActivity. The /products endpoint is the correct existing route on the backend. Fixes ANDROID-FY
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 864 864
Branches 65 65
=====================================
Misses 864 864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
HTTPClient.makeRequest()method to use the/productsendpoint instead of the non-existent/detailsendpoint.Problem
The
error_404button inMainActivitytriggersHTTPClient.makeRequest(), which sends a GET request to{domain}/details. However, the Flask backend atflask.empower-plant.comhas no/detailsroute — it only serves/products,/checkout,/product/0/info, etc. This causes every tap of that button to produce aSentryHttpClientException: HTTP Client Error with status code: 404.Fix
Changed the endpoint in
HTTPClient.makeRequest()from/detailsto/products, which is a valid GET endpoint on the Flask backend (the same one used byMainFragment.fetchToolsFromServer()).Fixes ANDROID-FY