Fix ArithmeticException divide-by-zero crash in MainActivity#218
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix ArithmeticException divide-by-zero crash in MainActivity#218cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Fixes ANDROID-G6 Removed the hardcoded 'int t = 5 / 0;' statement from the div_by_zero button's OnClickListener in MainActivity. This prevents the ArithmeticException that was thrown unconditionally when the button was clicked.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 864 863 -1
Branches 65 65
=====================================
+ Misses 864 863 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the ArithmeticException that was being thrown when the
div_by_zerobutton was clicked in MainActivity.Changes
int t = 5 / 0;statement from the div_by_zero button's OnClickListenerRoot Cause
The div_by_zero button's OnClickListener in MainActivity unconditionally executed
int t = 5 / 0;at line 53, which threw an ArithmeticException on every click. This was an intentional demo-crash trigger to showcase Sentry unhandled-exception capture, but has now been fixed to prevent the crash.Testing
The fix removes the divide-by-zero operation, allowing the button to be clicked without causing an application crash. The button will still add breadcrumbs to Sentry but will not throw an exception.
Fixes ANDROID-G6