Skip to content

feat: add release job for Java #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vytautas-astrauskas-sensmetry wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add release job for Java #116

vytautas-astrauskas-sensmetry wants to merge 1 commit into from

Conversation

@vytautas-astrauskas-sensmetry
Copy link
Collaborator

@vytautas-astrauskas-sensmetry vytautas-astrauskas-sensmetry commented Nov 13, 2025 •
edited
Loading

This PR is a draft because it does not fit our current publishing workflow. Our other workflows are not doing releases on tagged commits. Instead, we promote a specific nightly release into a normal release. This approach does not work with Maven because of two reasons:

  1. We need to choose whether we are building a snapshot or non-snapshot version before we start the build.
  2. The easiest way to publish releases to Maven central is by using the corresponding plugin, which cannot be easily split into the phases of building the deployment bundle and uploading the bundle.

@vytautas-astrauskas-sensmetry vytautas-astrauskas-sensmetry mentioned this pull request Nov 14, 2025
Merged
andrius-puksta-sensmetry
andrius-puksta-sensmetry reviewed Nov 14, 2025
View reviewed changes
andrius-puksta-sensmetry
andrius-puksta-sensmetry reviewed Nov 14, 2025
View reviewed changes
.github/workflows/js.yml Outdated
Copy link
Collaborator

@andrius-puksta-sensmetry andrius-puksta-sensmetry Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

@vytautas-astrauskas-sensmetry vytautas-astrauskas-sensmetry Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach in this PR is incompatible with our current publishing workflow. That is why I created #117 instead of trying to merge this PR. I will close this PR once I figured out how we should do the publishing.

andrius-puksta-sensmetry
andrius-puksta-sensmetry reviewed Nov 14, 2025
View reviewed changes
.github/workflows/python.yml Outdated
Copy link
Collaborator

@andrius-puksta-sensmetry andrius-puksta-sensmetry Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

andrius-puksta-sensmetry
andrius-puksta-sensmetry reviewed Nov 14, 2025
View reviewed changes
.github/workflows/test.yml Outdated
Copy link
Collaborator

@andrius-puksta-sensmetry andrius-puksta-sensmetry Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrius-puksta-sensmetry andrius-puksta-sensmetry andrius-puksta-sensmetry left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vytautas-astrauskas-sensmetry @andrius-puksta-sensmetry