Skip to content

Conversation

@uji
Copy link

@uji uji commented Apr 23, 2024

Fixes failed tests

  • Updated the year in the license from 2023 to 2024. The test fails because this description is out of date.
    rest_test.go:336: Incorrect Year in License Copyright
--- FAIL: TestLicenseYear (0.00s)
  • Replaces the experimental package golang.org/x/net/context used in Golang v1.7 and earlier contexts.
Run make test
go get -t -v ./...
get "golang.org/x/net/context": found meta tag vcs.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at //golang.org/x/net/context?go-get=1
get "golang.org/x/net/context": verifying non-authoritative meta tag
golang.org/x/net (download)
//go:build comment without // +build comment
github.com/sendgrid/rest (download)
make: *** [Makefile:4: install] Error 1
Error: Process completed with exit code 2.

Workflow successfully completed.
https://github.com/uji/rest/actions/runs/8804344592

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@uji uji closed this Apr 23, 2024
@uji uji reopened this Apr 23, 2024
@uji uji changed the title test: replace context package used in test to that of the standard package test: fixes failed tests Apr 23, 2024
@uji
Copy link
Author

uji commented Apr 26, 2024

Hi @SendGridDX team, is this repository currently being maintained? If possible, I would like to request a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant