Skip to content

Conversation

@AlaricWhitney
Copy link

Fixes

Adds Go Modules, and also adding a v2 directory as per current golang standards as per https://go.dev/blog/v2-go-modules.

This PR also makes minor adjustments to correct compatibility with Go 1.19.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@AlaricWhitney AlaricWhitney changed the title feat: Add Go Modules and add go 1.19 compatibility feat: Add Go Modules and add Go 1.19 compatibility Aug 18, 2022
@zwartho
Copy link

zwartho commented Jul 26, 2023

@twilio-dx what is the hold up on this PR? Go 1.17 is almost 2 years old at this point!

@marcoshuck
Copy link

@twilio-dx what is the hold up on this PR? Go 1.17 is almost 2 years old at this point!

+1

Would you consider creating a new PR with the latest versions included? I can give it a review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants