Skip to content

[UIK-2389][fullscreen-modal] update Header styles #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
j-mnizhek wants to merge 5 commits into
base: release/v17
Choose a base branch
from
Open

[UIK-2389][fullscreen-modal] update Header styles #2657

j-mnizhek wants to merge 5 commits into from

Conversation

@j-mnizhek
Copy link
Member

@j-mnizhek j-mnizhek commented Jan 14, 2026 •
edited
Loading

Changelog

@semcore/fullscreen-modal

Changed

  • Header styles, for the correct text behaviour and design ofc ✨

Motivation and Context

The previous design decision to place the description text on the same line with the title isn’t very good, both visually and technically, so I:

  • updated the layout to a column
  • added a <p> tag to the description
  • added a test story to check the behavior of a long title and description
  • updated documentation accordingly

How has this been tested?

Manually, with stories and different browsers

Screenshots

Current
image

New one
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@j-mnizhek j-mnizhek marked this pull request as ready for review January 14, 2026 12:24
@j-mnizhek j-mnizhek requested a review from ilyabrower January 14, 2026 12:53
ilyabrower
ilyabrower previously approved these changes Jan 14, 2026
View reviewed changes
@ilyabrower ilyabrower changed the base branch from release/v16 to release/v17 January 15, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabrower ilyabrower ilyabrower approved these changes

@Valeria-Zimnitskaya Valeria-Zimnitskaya Awaiting requested review from Valeria-Zimnitskaya

Assignees

No one assigned

Labels

accordion add-filter base-trigger breadcrumbs bulk-textarea card carousel checkbox color-picker d3-chart data-table date-picker drag-and-drop dropdown-menu errors feature-highlight feature-popover feedback-form fullscreen-modal icon inline-input input-tags link modal notice notice-bubble notice-global pagination radio select side-panel tag time-picker typography wizard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-mnizhek @ilyabrower